Implement kafka consumer and sink#162
Open
jaysonsantos wants to merge 3 commits intosnowplow:masterfrom
Open
Conversation
This should make kafka sources to send TSV files to S3
peel
approved these changes
Mar 16, 2020
peel
left a comment
peel
left a comment
There was a problem hiding this comment.
Hey Jayson, thanks for your contribution. It looks good to me, it would be fantastic if you could apply suggestions below.
src/main/scala/com.snowplowanalytics.s3/loader/IBufferedOutput.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com.snowplowanalytics.s3/loader/IBufferedOutput.scala
Outdated
Show resolved
Hide resolved
|
any update? |
Contributor
|
Sorry for going silent on this issue for so long! We've not merged this in as running the Snowplow pipeline on top of Kafka isn't currently a high priority for us, and being transparent it likely won't be for the forseeable future. As such we don't have a particularly good and repeatable way to test pipelines running on top of Kafka which has prevented us merging this, once it's in we need to be able to maintain it which is why this is at a standstill. We'll update this issue should anything change on this stance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make kafka sources able to send TSV files to S3